casper api logo

Casper CST Token Sale Security Audit

Reading Time: 3 minutes

  • 1
  •  
  •  
  •  
  •  
  •  
  •  
    1
    Share

Coinfabrik has been hired to audit the contracts for the Casper Token sale. Firstly, we will provide a summary of our discoveries and secondly, we will show the details of our findings.

Summary

The contracts audited are from the presale repository at https://github.com/Casper-dev/presale. The audit is based on the commit 3c66514423277c39bea26e62a7de47d51d712108 from branch feat/presale. This audit was updated to reflect the changes done on commit 8a702734c70e335661d21d04b9c995748d7b27b8 on the same branch.

The audited contracts are:

  • contracts/AdviserCasperToken.sol: An adviser token which can be converted directly to CST
  • contracts/CasperToken.sol: The token itself

The Casper token sale will have two phases: a presale one where each token will be sold at a fixed rate of $0.12 USD per token, and a sale one where they will be sold at $0.16 USD. There also is an adviser token sale contract which will be able to be exchanged 1:1 with the main token.

The following analyses were performed:

  • Misuse of the different call methods: call.value(), send() and transfer().
  • Integer rounding errors, overflow, underflow and related usage of SafeMath functions.
  • Old compiler version pragmas.
  • Race conditions such as reentrancy attacks or front-running.
  • Misuse of block timestamps, assuming anything other than them being strictly increasing.
  • Contract soft locking attacks (DoS).
  • Potential gas cost of functions being over the gas limit.
  • Missing function qualifiers and their misuse.
  • Fallback functions with a higher gas cost than the one that a transfer or send call allow.
  • Fraudulent or erroneous code.
  • Code and contract interaction complexity.
  • Wrong or missing error handling.
  • Overuse of transfers in a single transaction instead of using withdrawal patterns.
  • Insufficient analysis of the function input requirements.

Detailed findings

Minor severity

Possible overflow in purchase functions

In CasperToken.sol, there are lines in the purchase functions where a value is set with an addition, but these are unprotected against overflow. One of those is only callable by the contract owner, while the other one is public, in the functions purchaseWithBTC and purchaseWithPromoter. The lines which could be rewritten are the following:

And:

While the above was fixed in the latest commits, we’ve found the same possibility in the withdrawTeam function, in the latest commit., in the following:

Enhancements

Consistent use of SafeMath

In some parts of the code we’ve found lack of usage of SafeMath. We advise the use of the aforementioned code library in lines like:   

By forcing the use of such a code library the code is guaranteed to avoid situations like overflow.

Use of modern solidity compiler pragmas

The contracts provided use the following compiler pragmas:

We strongly suggest updating the compiler version, so as to avoid any possible legibility issues, since newer compiler versions include features such as distinguishing the constructor and event emission with keywords, which means the legibility of the contract is improved against possible future developments.

This observation has been fixed in the last commit sent to us.

Use of modifiers for commonly require clauses

The contract uses require clauses mixed in the function code. In general, the contract’s legibility could be improved by putting frequently used clauses in modifiers, by typing:

 

This issue has been fixed in the last commit, save for the redundant use in setMaxRate.

Conclusion

We found the contracts to be simple and straightforward and have a fair amount of documentation. Some minor issues have been found, but it is unlikely they could cause critical security problems in the future. After contacting Casper development team, these minor issues were fixed in the subsequent commits.

Do you want to know what is Coinfabrik Auditing Process?

Check our A-Z Smart Contract Audit Guide or you could request a quote for your project.


  • 1
  •  
  •  
  •  
  •  
  •  
  •  
    1
    Share